André Staltz on Nostr: npub14wpg3…vr45w yeah, I agree. I recall some years ago working with someone (you ...
npub14wpg3t4v26tasylq424wd83fqar8cmtfhkf8nufwwjp08q60742s6vr45w (npub14wp…r45w) yeah, I agree. I recall some years ago working with someone (you don't know them) who was nitpicky about everything in the PR plus stuff not even in the PR, and it was horrible.
Nowadays my threshold for PR are pretty low: if the change only improves the codebase, causing no new problems, then it should be an approval. Too often reviews are demanding the PR creates an *ideal* situation, instead of an *improved* situation.
Nowadays my threshold for PR are pretty low: if the change only improves the codebase, causing no new problems, then it should be an approval. Too often reviews are demanding the PR creates an *ideal* situation, instead of an *improved* situation.