LezKoma on Nostr: Caching the pubkey for the nip05 makes sense. Config is a good place for it. A couple ...
Caching the pubkey for the nip05 makes sense. Config is a good place for it.
A couple of questions:
- RepoRef is used to directly map the 30617 event into a rust object?
- Should we add the nostr remote URL into the gitrepo event? It would reflect the choice of the repo owner how he wants to use it. For example, if my nip05 relays intersect with the repo relays, I will omit the relay hint. If they are distinct, I'll include. But it would be easier to just store the URL and use later, than to do the intersection repeatedly. And it's a problem for not cors-enabled nip05s on the web.
- Do you think it would make sense to further refactor the `coordinate` member of `NostrUrlDecoded`? If we could include the Coordinate members (identifier, pubkey, kind, relays) direct members of the `NostrUrlDecoded`, we could change pubkey to Option<pubkey>, and NostrUrlDecoded could hold the URL value after parsing but before looking up NIP05. Also, the duplication of the `identifier` wouldn't be needed. I duplicated that previously because I couln't instantiate Coordinate from a NIP05 nostr:// remote URL.
A couple of questions:
- RepoRef is used to directly map the 30617 event into a rust object?
- Should we add the nostr remote URL into the gitrepo event? It would reflect the choice of the repo owner how he wants to use it. For example, if my nip05 relays intersect with the repo relays, I will omit the relay hint. If they are distinct, I'll include. But it would be easier to just store the URL and use later, than to do the intersection repeatedly. And it's a problem for not cors-enabled nip05s on the web.
- Do you think it would make sense to further refactor the `coordinate` member of `NostrUrlDecoded`? If we could include the Coordinate members (identifier, pubkey, kind, relays) direct members of the `NostrUrlDecoded`, we could change pubkey to Option<pubkey>, and NostrUrlDecoded could hold the URL value after parsing but before looking up NIP05. Also, the duplication of the `identifier` wouldn't be needed. I duplicated that previously because I couln't instantiate Coordinate from a NIP05 nostr:// remote URL.