📅 Original date posted:2021-06-28 📝 Original message:Hi Andrew, I just have a ...

Salvatore Ingala [ARCHIVE] /

npub1lpk…74n4

2023-06-07 22:55:20

in reply to nevent1q…kfpf

📅 Original date posted:2021-06-28
📝 Original message:Hi Andrew,

I just have a small suggestion on this proposal.

On Tue, 22 Jun 2021 at 23:29, Andrew Chow via bitcoin-dev <
bitcoin-dev at lists.linuxfoundation.org> wrote:

> | Taproot Leaf Script
> | <tt>PSBT_IN_TAP_LEAF_SCRIPT = 0x15</tt>
> | <tt><control block></tt>
> | The control block for this leaf as specified in BIP 341. The control
> block contains the merkle tree path to this leaf.
> | <tt><script> <8-bit uint></tt>
> | The script for this leaf as would be provided in the witness stack
> followed by the single byte leaf version.
>

So far, all the defined PSBT types had a relatively short keydata (not much
bigger than a couple of pubkeys).
I think that is a desirable property to keep, as it is often a reasonable
assumption that dictionary keys are not very large.
The control block as per BIP 341 can be up to 33 + 32*128 = 4129 bytes long.

Perhaps it would be better to split this into PSBT_IN_TAP_LEAF_SCRIPT
and PSBT_IN_TAP_LEAF_CONTROL_BLOCK (both with no keydata)?

Best,
Salvatore Ingala
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20210628/ce41048c/attachment.html>;

Author Public Key

npub1lpkmxpl2zhk0w30vtdz7s64ml9644k785eggmjsjgs7wman3szzqac74n4

Seen on

wss://relay.nostr.band

Show more details

Published at

2023-06-07 22:55:20

Kind type

1 Short Text Note

Event JSON

{ "id": "e350971922fb24536b7aab280b96c5637a9f7d2d0fea143d42d5bd40fd1130f2", "pubkey": "f86db307ea15ecf745ec5b45e86abbf9755adbc7a6508dca12443cedf6718084", "created_at": 1686178520, "kind": 1, "tags": [ [ "e", "1998ce9d04ace2535019f37d7145ee922e0b6bba122df280530581749ee118ab", "", "root" ], [ "e", "531065461ffb56a2c99c126f6d26109a9e26218fff2f1fd7df99c51099920855", "", "reply" ], [ "p", "4a273da3c9ab85c096f859e6ca066d2fdfe762406cadc2f4d58aa75468aca8d0" ] ], "content": "📅 Original date posted:2021-06-28\n📝 Original message:Hi Andrew,\n\nI just have a small suggestion on this proposal.\n\nOn Tue, 22 Jun 2021 at 23:29, Andrew Chow via bitcoin-dev \u003c\nbitcoin-dev at lists.linuxfoundation.org\u003e wrote:\n\n\u003e | Taproot Leaf Script\n\u003e | \u003ctt\u003ePSBT_IN_TAP_LEAF_SCRIPT = 0x15\u003c/tt\u003e\n\u003e | \u003ctt\u003e\u003ccontrol block\u003e\u003c/tt\u003e\n\u003e | The control block for this leaf as specified in BIP 341. The control\n\u003e block contains the merkle tree path to this leaf.\n\u003e | \u003ctt\u003e\u003cscript\u003e \u003c8-bit uint\u003e\u003c/tt\u003e\n\u003e | The script for this leaf as would be provided in the witness stack\n\u003e followed by the single byte leaf version.\n\u003e\n\nSo far, all the defined PSBT types had a relatively short keydata (not much\nbigger than a couple of pubkeys).\nI think that is a desirable property to keep, as it is often a reasonable\nassumption that dictionary keys are not very large.\nThe control block as per BIP 341 can be up to 33 + 32*128 = 4129 bytes long.\n\nPerhaps it would be better to split this into PSBT_IN_TAP_LEAF_SCRIPT\nand PSBT_IN_TAP_LEAF_CONTROL_BLOCK (both with no keydata)?\n\nBest,\nSalvatore Ingala\n-------------- next part --------------\nAn HTML attachment was scrubbed...\nURL: \u003chttp://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20210628/ce41048c/attachment.html\u003e", "sig": "e2e29167d183d39815f608b09717fa69796428e8a4f31e6b00c39d40bb153ef613a13b4b8ad71809a622cc6fcbeaaea1eff56c8b4874096f61e08b0ff59eafe5" }