laanwj on Nostr: hah you could say so ! i had been arguing to remove miniupnp since i had a ...

hah you could say so !

i had been arguing to remove miniupnp since i had a CVE-2015-6031 based local network code execution exploit PoC, but back in the day people were really hesitant to remove it, because of potentially losing connectable nodes, and at some point i gave up

it looks that that sentiment changed over time; that was one of the most popular (and least controversial) PRs in a while 😀

i guess having a built-in NATPMP/PCP implementation made the last ones change their mind