Rusty Russell on Nostr: Simple rework PR up. I also want to update your BOLT11 parser to the latest (it's ...
Simple rework PR up. I also want to update your BOLT11 parser to the latest (it's buggy).
I need to think harder about your cursor API: my instinct is to split it into two types, one for reading, one for writing. But you do a lot of lookahead in your parsing, so the classic "mark cursor invalid if we hit an error" pattern doesn't fit. Hmm....
Published at
2024-08-17 06:27:15Event JSON
{
"id": "33aa54284776007f874fd6246b3cb444d607b710d0faa44bcaba7c3098e5e0ce",
"pubkey": "f1725586a402c06aec818d1478a45aaa0dc16c7a9c4869d97c350336d16f8e43",
"created_at": 1723876035,
"kind": 1,
"tags": [
[
"e",
"2747971a204800ee61ed868ccf281a3347d10b84336ff89ac19819a013489cb8",
"",
"root"
],
[
"e",
"9c442067615e10e6e7f993ad66c3cc9e77ac18c752d5f7aeb8940c7c8c5ad06a"
],
[
"e",
"815e53762e0b19caeef19df2605250f65863b040c08e4cebb67dc6b6eb70f430",
"",
"reply"
],
[
"p",
"f1725586a402c06aec818d1478a45aaa0dc16c7a9c4869d97c350336d16f8e43"
],
[
"p",
"32e1827635450ebb3c5a7d12c1f8e7b2b514439ac10a67eef3d9fd9c5c68e245"
]
],
"content": "Simple rework PR up. I also want to update your BOLT11 parser to the latest (it's buggy).\n\nI need to think harder about your cursor API: my instinct is to split it into two types, one for reading, one for writing. But you do a lot of lookahead in your parsing, so the classic \"mark cursor invalid if we hit an error\" pattern doesn't fit. Hmm....",
"sig": "4c37a9268e92cd282bc0af0040215c8ac23b299bab273aa66f009c7bf4f6f1cc0e3b1a2671085cfee9bd042604289b32c5b6a80d6bda6df2e53330e8c9a25901"
}