Event JSON
{
"id": "87cd457f925f7172332fd18e7a8d748b3cb021deed1a0450514ae3f482163b03",
"pubkey": "ee9d979e7e1418a9f7472baf82dc96082a0d4251b77bcb170a6ecec93fadff64",
"created_at": 1732090213,
"kind": 1,
"tags": [
[
"e",
"263f70c0272a73cc11fd6084805c4b1a685424fce11bcc2b42c76207e3e8c989",
"",
"root"
],
[
"e",
"69515a2fc1cd0e215c0ac1da40179e70e77f7b2a37532e50fb4db768f6d77f27"
],
[
"e",
"a2fe99424e2ffecd96206bc7ff72c709536bb98830593304278455045f933763",
"",
"reply"
],
[
"p",
"ee9d979e7e1418a9f7472baf82dc96082a0d4251b77bcb170a6ecec93fadff64"
],
[
"p",
"3ffac3a6c859eaaa8cdddb2c7002a6e10b33efeb92d025b14ead6f8a2d656657"
],
[
"p",
"3efdaebb1d8923ebd99c9e7ace3b4194ab45512e2be79c1b7d68d9243e0d2681"
],
[
"p",
"e2ccf7cf20403f3f2a4a55b328f0de3be38558a7d5f33632fdaaefc726c1c8eb"
],
[
"p",
"266815e0c9210dfa324c6cba3573b14bee49da4209a9456f9484e5106cd408a5"
],
[
"p",
"17538dc2a62769d09443f18c37cbe358fab5bbf981173542aa7c5ff171ed77c4"
],
[
"p",
"32e1827635450ebb3c5a7d12c1f8e7b2b514439ac10a67eef3d9fd9c5c68e245"
],
[
"r",
"https://github.com/fiatjaf/khatru/blob/76ecf4f7914a93b7ec4f0cc0c823304a7402adab/blossom/server.go#L18"
]
],
"content": "Looking good! If you’re open to a small suggestion, and if fiatjaf doesn’t mind introducing some early-stage backwards-incompatible changes to khatru's Blossom’s API, I think you could simplify things by changing the return type here https://github.com/fiatjaf/khatru/blob/76ecf4f7914a93b7ec4f0cc0c823304a7402adab/blossom/server.go#L18 to `io.ReadSeeker`. This would allow you to eliminate the `io.Copy` fallback code and the `Content-Type` handling, as `http.ServeContent` also takes care of that for you. It even handles ETags and cache-related headers, so I’d expect your patch to significantly improve things for all clients—not just iOS. Well done!",
"sig": "2ff3b089d67aa75f4e1902e36e0b66d4858daaac6f91b1cc91c32857f252b29724d4d5606937ab6383b9acbd19469caa35c369bebf1ecf63bf558c7d3c90a915"
}
