Eric Voskuil [ARCHIVE] on Nostr: 📅 Original date posted:2019-10-17 📝 Original message:As this is a P2P protocol ...
📅 Original date posted:2019-10-17
📝 Original message:As this is a P2P protocol change it should be exposed as a version increment (and a BIP), not just as a conditional service. If the intent is to retain this protocol indefinitely, exposing it conditionally, then a service bit would make sense, but it remains a protocol change.
BIP61 is explicit:
“All implementations of the P2P protocol version 70,002 and later should support the reject message.“
e
> On Oct 17, 2019, at 12:54, Andreas Schildbach via bitcoin-dev <bitcoin-dev at lists.linuxfoundation.org> wrote:
>
> On 16/10/2019 18.43, John Newbery via bitcoin-dev wrote:
>
>> Following discussion on this mailing list, support for BIP 61 REJECT
>> messages was not removed from Bitcoin Core in V0.19. The behaviour in
>> that upcoming release is that REJECT messages are disabled by default
>> and can be enabled using the `-enablebip61` command line option.
>
> Is there a NODE_* bit we can use to pick peers that support this
> (useful!) feature?
>
>
> _______________________________________________
> bitcoin-dev mailing list
> bitcoin-dev at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
📝 Original message:As this is a P2P protocol change it should be exposed as a version increment (and a BIP), not just as a conditional service. If the intent is to retain this protocol indefinitely, exposing it conditionally, then a service bit would make sense, but it remains a protocol change.
BIP61 is explicit:
“All implementations of the P2P protocol version 70,002 and later should support the reject message.“
e
> On Oct 17, 2019, at 12:54, Andreas Schildbach via bitcoin-dev <bitcoin-dev at lists.linuxfoundation.org> wrote:
>
> On 16/10/2019 18.43, John Newbery via bitcoin-dev wrote:
>
>> Following discussion on this mailing list, support for BIP 61 REJECT
>> messages was not removed from Bitcoin Core in V0.19. The behaviour in
>> that upcoming release is that REJECT messages are disabled by default
>> and can be enabled using the `-enablebip61` command line option.
>
> Is there a NODE_* bit we can use to pick peers that support this
> (useful!) feature?
>
>
> _______________________________________________
> bitcoin-dev mailing list
> bitcoin-dev at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev