Dan Luu on Nostr: The bug here is that if you write an unexpected author line, the regex looking for an ...
The bug here is that if you write an unexpected author line, the regex looking for an author keeps scanning until it finds another author line (which is fake!):
https://iter.ca/post/gh-sig-pwn/If you wrote a parser and it encountered unexpected stuff, it seems pretty standard to error out when you run into unexpected stuff and not just keep consuming and throwing away input until it matches something expected.
Am I missing something here?
Published at
2024-01-24 22:11:44Event JSON
{
"id": "a615bb8c743d27ccf342c016eb91cc212b21e7371c616d7797009b2cb1a63255",
"pubkey": "0ecb1c9b6fc91390ab51a5a39082f44c4abe0a19ad67c63b709d175ebf23e0f2",
"created_at": 1706134304,
"kind": 1,
"tags": [
[
"e",
"b935b7fb48c48c8c351e9fe87ac25f51aca377709c3e3c051d750199fd0d85ad",
"wss://relay.mostr.pub",
"reply"
],
[
"proxy",
"https://mastodon.social/users/danluu/statuses/111813217773163231",
"activitypub"
]
],
"content": "The bug here is that if you write an unexpected author line, the regex looking for an author keeps scanning until it finds another author line (which is fake!): https://iter.ca/post/gh-sig-pwn/\n\nIf you wrote a parser and it encountered unexpected stuff, it seems pretty standard to error out when you run into unexpected stuff and not just keep consuming and throwing away input until it matches something expected.\n\nAm I missing something here?",
"sig": "d77f626b179f2bc7e468d6e5a07e689f2fc48edfee8a7f154aeddf9270671ca5d6638830aa71f83a1b8ab9b7c887a3b0770d4ff7ed0a73133f666a7fae3135f4"
}
