Bashy on Nostr: I originally made that script (single file) to allow myself to get a lightning ...
I originally made that script (single file) to allow myself to get a lightning address easily with one single file, and then decided to publish in case there's someone else in the same situation.
I love your PR because it allows it to make a real PHP package, and brings much rigor, but it's not a single file anymore, and doesn't fit my initial need when I wrote that single script.
I'm still thinking whether the best would be to make a new repo in a group where we can both contribute in the future or accept your PR and move my initial script in another repo.
As you bring much by this PR, I feel like I am not in a position to keep this repo under my personal GitHub space, in a way that I don't want to take full credit for your contribution.
I want to hear your thoughts, and I hope that you understand my position and I'm open to talk further about that.
Sorry to reply that late too!
Not the subject here but I'm also thinking about a more efficient way in the case there're several lightning address where each has its own data (backend type, backend endpoint, custom messages etc)
Feel free to DM/email
I love your PR because it allows it to make a real PHP package, and brings much rigor, but it's not a single file anymore, and doesn't fit my initial need when I wrote that single script.
I'm still thinking whether the best would be to make a new repo in a group where we can both contribute in the future or accept your PR and move my initial script in another repo.
As you bring much by this PR, I feel like I am not in a position to keep this repo under my personal GitHub space, in a way that I don't want to take full credit for your contribution.
I want to hear your thoughts, and I hope that you understand my position and I'm open to talk further about that.
Sorry to reply that late too!
Not the subject here but I'm also thinking about a more efficient way in the case there're several lightning address where each has its own data (backend type, backend endpoint, custom messages etc)
Feel free to DM/email