calle 👁️⚡👁️ on Nostr: 📢 Lightning devs - Let's get rid of the description_hash requirement in LNURL-pay ...
📢 Lightning devs - Let's get rid of the description_hash requirement in LNURL-pay
* achieves no goal but adds complexity
* LNURL for CLN without Rube Goldberg contraptions
* only wallets need to change, not Servers
* change is code removal, not addition
The original purpose of description_hash is to avoid MITM attacks - but it does not achieve that.
Furthermore, CLN in particular does not like invoices with only a description_hash - don't ask why, we've been trying to figure this out for over a year.
This PR finally gets rid of this requirement and we won't ever have to worry about CLN turning on an off description hash support.
Fiatjaf agrees - (joke's on me: I supported Drivechain before but apparently he didn't know (end sarcasm)).
You can verify whether your wallet acts as intended in this PR if you can pay to this Lightning address hosted on a node that runs Breez + Greenlight (doesn't support deschashonly invoices):
⚡ calle@legend.8333.space
Please leave your comments in the PR and get ready to remove unnecessary code from wallets (feels good right?).
Do you rely on this feature in any way?
https://github.com/lnurl/luds/pull/234
* achieves no goal but adds complexity
* LNURL for CLN without Rube Goldberg contraptions
* only wallets need to change, not Servers
* change is code removal, not addition
The original purpose of description_hash is to avoid MITM attacks - but it does not achieve that.
Furthermore, CLN in particular does not like invoices with only a description_hash - don't ask why, we've been trying to figure this out for over a year.
This PR finally gets rid of this requirement and we won't ever have to worry about CLN turning on an off description hash support.
Fiatjaf agrees - (joke's on me: I supported Drivechain before but apparently he didn't know (end sarcasm)).
You can verify whether your wallet acts as intended in this PR if you can pay to this Lightning address hosted on a node that runs Breez + Greenlight (doesn't support deschashonly invoices):
⚡ calle@legend.8333.space
Please leave your comments in the PR and get ready to remove unnecessary code from wallets (feels good right?).
Do you rely on this feature in any way?
https://github.com/lnurl/luds/pull/234