Pieter Wuille [ARCHIVE] on Nostr: 📅 Original date posted:2015-01-22 📝 Original message:On Wed, Jan 21, 2015 at ...
📅 Original date posted:2015-01-22
📝 Original message:On Wed, Jan 21, 2015 at 11:18 PM, Matt Whitlock <bip at mattwhitlock.name> wrote:
> To be more in the C++ spirit, I would suggest changing the (const std::vector<unsigned char> &sig, size_t &off) parameters to (std::vector<unsigned char>::const_iterator &itr, std::vector<unsigned char>::const_iterator end).
I agree that is more in the spirit of C++, but part of the motivation
for including C++ code that it mostly matches the exact code that has
been used in the past two major Bitcoin Core releases (to interpret
signatures as standard).
--
Pieter
📝 Original message:On Wed, Jan 21, 2015 at 11:18 PM, Matt Whitlock <bip at mattwhitlock.name> wrote:
> To be more in the C++ spirit, I would suggest changing the (const std::vector<unsigned char> &sig, size_t &off) parameters to (std::vector<unsigned char>::const_iterator &itr, std::vector<unsigned char>::const_iterator end).
I agree that is more in the spirit of C++, but part of the motivation
for including C++ code that it mostly matches the exact code that has
been used in the past two major Bitcoin Core releases (to interpret
signatures as standard).
--
Pieter